Skip to content

Sanitize sourceattribution in mapbox layers #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2020
Merged

Sanitize sourceattribution in mapbox layers #4793

merged 4 commits into from
Apr 30, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 30, 2020

@archmoj archmoj added this to the v1.54.0 milestone Apr 30, 2020
alexcjohnson
alexcjohnson reviewed Apr 30, 2020
View reviewed changes
test/jasmine/tests/svg_text_utils_test.js Outdated
describe('sanitizeHTML', function() {
'use strict';

describe('convertToTspans', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not testing convertToTspans here, can we remove this level of nesting?

alexcjohnson
alexcjohnson approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small comment about test blocks but the functionality of the tests is perfect. 💃

@archmoj archmoj changed the title Sanitize sourcesttribution in mapbox layers Sanitize sourceattribution in mapbox layers Apr 30, 2020
@archmoj archmoj merged commit 662f51a into master Apr 30, 2020
@archmoj archmoj deleted the sanitizeHTML branch April 30, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.54.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson